-
-
Notifications
You must be signed in to change notification settings - Fork 41
Updated ref arch content #405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Deploy preview for keen-clarke-470db9 ready! Built with commit 8c08a69 |
josh-padnick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for taking the lead on this! It's always the item I never get to. Left a few small comments, but otherwise this is ready to merge!
Co-authored-by: Josh Padnick <josh@gruntwork.io>
|
Thanks for the review! Just incorporated all the feedback. Please approve and we'll be good to ship it! |
|
@eak12913 @oredavids @ebeneliason Could we get a rubber stamp on this? Regrettably, I've become a contributor and can't merge myself. |
|
@josh-padnick if you hit approve, I believe we can still merge this, since the primary commit author for the suggestions is still Ben. |
|
@yorinasub17 The issue is that I made suggestions which Ben accepted, making me a contributor. I know, I hate this! |
|
What Yori is saying is that even though I accepted your suggestions and you became a committer, you can still approve by going to Files and Approve. After approving you should see the button turn green to merge. We confirmed this behavior on the service catalog and other repos. |
|
Oh my gosh, I did not know this! What a revelation. @ebeneliason @oredavids @eak12913 Note that code committers can still go to files / approve on PRs to approve them. |
|
@josh-padnick do we tend to leave branches around for the public website? If not, probably want to delete this. |
|
Ah good call. Deleted now. |
Updated the reference architecture product page with the new diagram and copy. Also dropped references to GCP. Please review with an eye for typos! 👀
Hero and subhero content:

Updated diagram:

How it works:

More detail:

Now with hundreds of customers! (instead of 70):

New security features:
